[systemd-devel] [PATCH 1/2] udev: use "bit" as unit for network card speeds

Jan Engelhardt jengelh at inai.de
Mon Nov 11 22:06:16 PST 2013


On Tuesday 2013-11-12 06:34, David Timothy Strauss wrote:

>On Tue, Nov 12, 2013 at 3:27 PM, Jan Engelhardt <jengelh at inai.de> wrote:
>      As far as I can see, ethtool-util.c in systemd merely passes
>      that on to
>      ethtool, and /usr/include/linux/ethtool.h says "MBps" in its
>      comments.
>
>
>The capitalized "B" is generally "bytes."

Perhaps, but then you would still have to explain how you would encode 
fraction in "12.5" MBytes/s into the the unsigned ints that are used 
in all places.

In any case, even if the ethtool structures awkwardly specified the use 
of "bytes", the user-visible part should be in "bits", and this patch 
was to give an impetus.


More information about the systemd-devel mailing list