[systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

Patrik Flykt patrik.flykt at linux.intel.com
Wed Nov 13 14:11:44 PST 2013


	Hi,

On Thu, 2013-11-14 at 06:31 +0900, Greg KH wrote:

> Nice stuff.  Where did this code come from, conman?  If so, for some
> reason I thought that it would be easier to make a library of the
> existing conman dhcp code and have both projects use it instead of
> forking and having two copies?

Looking more carefully at the code in ConnMan started to reveal the
relative age of the DHCP client part and showed some interesting code
that might not be entirely correct. After removing the GLib main loop
parts not too much valuable code was left behind. I have kept one eye in
the existing code to find additions for picky servers so I hope the
lessons learned have not been lost. I'm more positive with the DHCPv6
part, that implementation has more reusable parts.

I'm not too worried about having two copies for now, the one in ConnMan
would have met its fate anyway a bit later.


Cheers,

	Patrik



More information about the systemd-devel mailing list