[systemd-devel] [PATCH 05/28] dhcp: Add option appending and parsing

[Lennart Poettering]

On Wed, 13.11.13 23:22, Patrik Flykt (patrik.flykt at linux.intel.com) wrote:

> +int __dhcp_option_append(uint8_t **buf, int *buflen, uint8_t code,
> +                         uint8_t optlen, void *optval);
> +

The "__" prefix is actually private property by the C compiler,
according to ANSI C. Please do not define your own symbols in this
namespace. (Also why even?)

> +int __dhcp_option_append(uint8_t **buf, int *buflen, uint8_t code,
> +                         uint8_t optlen, void *optval)

Shouldn't "void *optval" be const?

Lennart

-- 
Lennart Poettering, Red Hat