[systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

Martin Pitt martin.pitt at ubuntu.com
Thu Nov 14 09:05:55 PST 2013


Martin Pitt [2013-11-14 17:53 +0100]:
> So option 1 is to update the patch to not rely on "uid", but instead
> always get it from PAM.

I went through all instances of using the uid, username, or pw, and I
cannot find any place in the PAM module where we would actually want
the originating user name, so I retract this.

> Option 2 is to never read it from loginuid, as that's indeed not
> what one should be concerned about in a PAM module.
> Attached patch is doing option 2. 

... and hence I'm convinced that this is the right thing to do.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20131114/b54092bb/attachment.pgp>


More information about the systemd-devel mailing list