[systemd-devel] [PATCH 02/28] dhcp: Add DHCP client initialization

[Patrik Flykt]

	Hi,

On Thu, 2013-11-14 at 01:01 +0100, Lennart Poettering wrote:

> Hmm, "struct in_addr" contains nothing but a uint32_t. It really
> sounds
> overkill allocating such a structure individually on the
> stack. Shouldn't this structure be directly inside DHCPClient? Or
> actually, do we really want to use struct in_addr at all? It sounds so
> useless, a "uint_32_t" sounds so much simpler, and easier to use... 

Agree, uint32_t is much simpler here in the DHCPv4 case. For v6
something like a struct is needed, but that's another and later story.

Cheers,

	Patrik