[systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

Colin Guthrie gmane at colin.guthr.ie
Tue Nov 19 14:38:38 PST 2013


'Twas brillig, and Colin Walters at 19/11/13 18:13 did gyre and gimble:
> +d /run/user/0 0755 root root 10d

This should probably be 0700 like the runtime dirs usually are I think.

Also won't this folder be naturally reaped in user_finalize() in
login/logind-user.c:

        /* Kill XDG_RUNTIME_DIR */
        k = user_remove_runtime_path(u);

e.g. if you really do login as root, then logout again, it'll kill this
folder, and thus the tmpfiles stuff only helps up until root logs in
directly then logs out again after which point the folder is gone and
we're snookered.

So you likely need to suppress the tidyup for root too unless I've
misunderstood something.

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/


More information about the systemd-devel mailing list