[systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

[Colin Walters]

On Thu, 2013-11-21 at 00:36 +0100, Lennart Poettering wrote:
> On Tue, 19.11.13 13:13, Colin Walters (walters at verbum.org) wrote:
> 
> > Anyways, new tested patch attached.  Lennart, any objections?
> 
> Yes. Let's not tape over problems and pretend things could work if we
> freely mix and match things.

I am not freely mixing and matching.  I am solely targeting
XDG_RUNTIME_DIR.

> I do like Martin's original patch, since by unsetting XDG_RUNTIME_DIR it
> basically tells apps "Hey, all bets are off, you are fucked", and
> doesn't pretend XDG_RUNTIME_DIR would still work. Because it doesn't.

My patch *also* unsets it for every uid except 0, which I make always
work.  Did you read it?  Under what scenarios will my patch cause
failures that did not already exist?