[systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

[Lennart Poettering]

On Tue, 19.11.13 17:12, David Timothy Strauss (david at davidstrauss.net) wrote:

> 
> I'm pretty confident in the accuracy of the controller mask
> aggregation, especially given the new unit test. Here are the main
> review questions.

Ahum. Please do not just commit stuff like this that is not obvious and
touches the core without review. "make distcheck" is broken now.

I am fine if commiters commit without review if it's in their "own"
submodule, or if it's man pages, or really obvious things. But this
commit does not qualify. It touches the core, and it is far from obvious
to me. It includes lines like "TODO" which are a good indication that
this isn't even thought out to the end...

Please, for stuff like this get a review from Kay, Zbigniew, Michal
Schmidt, or me, before you commit. Thanks!

Lennart

-- 
Lennart Poettering, Red Hat