[systemd-devel] [PATCH v2 15/26] dhcp: Add test for discover DHCP packet creation

[Patrik Flykt]

Set a fake MAC address and emulate raw packet sending. When the buffer
containing the Discover message is received, check selected IP and
UDP headers and compute IP header and UDP message checksums. Also
send the DHCP message for option parsing and expect a successful
outcome.
---
 Makefile.am                 |    3 ++
 src/dhcp/test-dhcp-client.c |   80 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+)

diff --git a/Makefile.am b/Makefile.am
index b038e07..3f698b5 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -3781,6 +3781,9 @@ test_dhcp_option_LDADD = \
 test_dhcp_client_SOURCES = \
 	src/dhcp/protocol.h \
 	src/systemd/sd-dhcp-client.h \
+	src/dhcp/internal.h \
+	src/dhcp/option.h \
+	src/dhcp/option.c \
 	src/dhcp/client.c \
 	src/dhcp/test-dhcp-client.c
 
diff --git a/src/dhcp/test-dhcp-client.c b/src/dhcp/test-dhcp-client.c
index c6a9eb1..03bf348 100644
--- a/src/dhcp/test-dhcp-client.c
+++ b/src/dhcp/test-dhcp-client.c
@@ -24,9 +24,16 @@
 #include <errno.h>
 #include <stdio.h>
 
+#include "util.h"
+
 #include "protocol.h"
+#include "internal.h"
 #include "sd-dhcp-client.h"
 
+static struct ether_addr mac_addr = {
+        .ether_addr_octet = {'A', 'B', 'C', '1', '2', '3'}
+};
+
 static void test_request_basic(void)
 {
         DHCPClient *client;
@@ -112,10 +119,83 @@ static void test_checksum(void)
         assert(client_checksum(&buf, 20) == *val);
 }
 
+static int check_options(uint8_t code, uint8_t len, uint8_t *option,
+                void *user_data)
+{
+        return 0;
+}
+
+int dhcp_network_send_raw_packet(int index, void *packet, int len)
+{
+        int size;
+        DHCPPacket *discover;
+        uint16_t ip_check, udp_check;
+        int res;
+
+        assert(index == 42);
+        assert(packet);
+
+        size = sizeof(DHCPPacket) + 4;
+        assert(len > size);
+
+        discover = packet;
+
+        assert(memcmp(discover->dhcp.chaddr,
+                      &mac_addr.ether_addr_octet, 6) == 0);
+        assert(discover->ip.ttl == IPDEFTTL);
+        assert(discover->ip.protocol == IPPROTO_UDP);
+        assert(discover->ip.saddr == INADDR_ANY);
+        assert(discover->ip.daddr == INADDR_BROADCAST);
+        assert(discover->udp.source == ntohs(DHCP_PORT_CLIENT));
+        assert(discover->udp.dest == ntohs(DHCP_PORT_SERVER));
+
+        ip_check = discover->ip.check;
+
+        discover->ip.ttl = 0;
+        discover->ip.check = discover->udp.len;
+
+        udp_check = ~client_checksum(&discover->ip.ttl, len - 8);
+        assert(udp_check == 0xffff);
+
+        discover->ip.ttl = IPDEFTTL;
+        discover->ip.check = ip_check;
+
+        ip_check = ~client_checksum(&discover->ip, sizeof(discover->ip));
+        assert(ip_check == 0xffff);
+
+        size = len - sizeof(struct iphdr) - sizeof(struct udphdr);
+
+        res = dhcp_option_parse(&discover->dhcp, size, check_options, NULL);
+        if (res < 0)
+                return res;
+
+        return 575;
+}
+
+static void test_discover_message(void)
+{
+        DHCPClient *client;
+        int res;
+
+        client = sd_dhcp_client_new();
+        assert(client);
+
+        assert(sd_dhcp_client_set_index(client, 42) >= 0);
+        assert(sd_dhcp_client_set_mac(client, &mac_addr) >= 0);
+
+        assert(sd_dhcp_client_set_request_option(client, 248) >= 0);
+
+        res = sd_dhcp_client_start(client);
+
+        assert(res == 575 || res == -EINPROGRESS);
+}
+
 int main(int argc, char *argv[])
 {
         test_request_basic();
         test_checksum();
 
+        test_discover_message();
+
         return 0;
 }
-- 
1.7.10.4