[systemd-devel] [PATCH v2 19/26] dhcp: Add timeout and main loop support

[Zbigniew Jędrzejewski-Szmek]

On Wed, Nov 27, 2013 at 04:57:19PM +0200, Patrik Flykt wrote:
> 
> 	Hi,
> 
> On Tue, 2013-11-26 at 05:32 +0100, Zbigniew Jędrzejewski-Szmek wrote:
> > > +static int client_timeout_resend(sd_event_source *s, uint64_t usec,
> > > +                                 void *userdata)
> > > +{
> ...
> > > +
> > > +        return 0;
> > > +
> > > +error:
> > > +        client_stop(client, err);
> > > +
> > > +        return 0;
> > Return err?
> 
> Here I didn't want to spill the error back to the event handling loop
> code as the situation is handled internally by stopping the client and
> giving the error reason to a registered callback (in patch 25/26) via
> 'client_stop()'.
Oh, OK. So maybe add a comment, this will help avoid misunderstandings
in the future :)

Zbyszek