[systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

[Lennart Poettering]

On Wed, 27.11.13 19:48, David Herrmann (dh.herrmann at gmail.com) wrote:

> +        /* skip interface, but allow callers to do that themselves */
> +        sd_bus_message_skip(m, "s");

This feels a bit like taping over bugs. I'd suggest adding an additional
parameter "const char **interface" to the function which if non-NULL is
updated with the interface name. If it is NULL we'd just skip th
interface as above...

if (interface)
      r = sd_bus_message_read("s", interface);
else
      r = sd_bus_message_skip(m, "s");

...

Lennart

-- 
Lennart Poettering, Red Hat