[systemd-devel] [PATCH] fstab-generator: When parsing the root= cmdline option, set FsckPassNo to 1

[Thomas Bächler]

Am 04.10.2013 13:52, schrieb Zbigniew Jędrzejewski-Szmek:
>>> Colin had the great idea that we drop mask root-fsck.service in
>> /run/systemd/system/ when we run fsck in initrd. For example, the initrd
>> generator could add a service to the initrd that creates the symlink and
>> a .d snippet that makes systemd-fsck at .service require it. This would
>> work without complex changes to the systemd core and hopefully cover all
>> cases.
> Hm, why not add ConditionKernelCommandLine=!ro instead to
> systemd-root-fsck.service?

I looked into it and decided against it, since it is not the correct
test case: You can have fsck in initrd and still mount ro - then
systemd-root-fsck will still start and you will have the double-fsck again.

Actually, what you propose is the same as having systemd-root-fsck with
ConditionReadWrite=!/, which is already in place.

> ('rw' is the default, the lack of 'ro'
> means 'rw'.)

Line 383 in src/fstab-generator/fstab-generator.c disagrees.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20131004/cbd8b138/attachment.pgp>