[systemd-devel] [PATCH] make fsck fix mode a kernel command line option

[Karel Zak]

On Tue, Sep 10, 2013 at 04:55:19PM +0100, Colin Guthrie wrote:
> 'Twas brillig, and Tom Gundersen at 10/09/13 13:45 did gyre and gimble:
> > On Tue, Sep 10, 2013 at 2:31 PM, Jan Engelhardt <jengelh at inai.de> wrote:
> >>
> >> On Tuesday 2013-09-10 13:52, Dave Reisner wrote:
> >>>> the FUSE program knows
> >>>> nothing about the systemd-specific "nofail" or "x-*".

 We have "nofail" since 2007 in mount(8) (by patch from Suse:-),
 since 2009 in fsck(8) and since 2010 in swapon(8).

 Note that mount(8) does not strip "nofail" when call mount.<type>
 helpers.

> >>> This should only be a problem if you directly use the FUSE mount helper.
> >>> If you instead invoke mount with -t fuse.$fusetype, then this isn't an
> >>> issue. mount(8) *does* understand these options and nicely strips them
> >>> out before invoking the specific mount helper for you.
> >>
> >> If it were so that mount stripped them, I would not be reporting it,
> >> would I. Or maybe that is a feature of a future util-linux?
> >>
> >> # grep /mnt /etc/fstab
> >> /srv/www /mnt fuse.bindfs auto,nofail,group=company,perms=g+rw,create-for-group=www,create-with-perms=g+r:go-w 0 0
> >> # mount /mnt
> >> fuse: unknown option `nofail'
> >> # rpm -q util-linux
> >> util-linux-2.21.2-10.2.1.x86_64

 hmm... we have 2.24-rc1 now ;-)

> > Hm, I thought that feature was part of 2.21... or perhaps your distro
> > is still not using the libmount based mount?

 BTW, v2.24 is probably last release with old deprecated non-libmount
 based mount(8).

> I suspect this issue (libmount based mount) as this is what hit us a
> while back (I think our problem there was not using libmount in
> nfs-utils rather than mount itself, but my memory is fuzzy and I could
> be getting this wrong)

 It's really really bad idea to use old deprecated mount(8) on system
 with systemd. The old mount code is completely frozen in last years, 
 no new features at all...

    Karel

-- 
 Karel Zak  <kzak at redhat.com>
 http://karelzak.blogspot.com