[systemd-devel] [PATCH] bus: fix duplicate comparisons
Tero Roponen
tero.roponen at gmail.com
Wed Oct 9 22:14:24 PDT 2013
Testing for y > x is the same as testing for x < y.
diff --git a/src/libsystemd-bus/sd-event.c b/src/libsystemd-bus/sd-event.c
index 069e4fb..de96fde 100644
--- a/src/libsystemd-bus/sd-event.c
+++ b/src/libsystemd-bus/sd-event.c
@@ -144,7 +144,7 @@ static int pending_prioq_compare(const void *a, const void *b) {
/* Stability for the rest */
if (x < y)
return -1;
- if (y > x)
+ if (x > y)
return 1;
return 0;
@@ -179,7 +179,7 @@ static int prepare_prioq_compare(const void *a, const void *b) {
/* Stability for the rest */
if (x < y)
return -1;
- if (y > x)
+ if (x > y)
return 1;
return 0;
@@ -212,7 +212,7 @@ static int time_prioq_compare(const void *a, const void *b) {
/* Stability for the rest */
if (x < y)
return -1;
- if (y > x)
+ if (x > y)
return 1;
return 0;
More information about the systemd-devel
mailing list