[systemd-devel] [PATCH] bus: fix duplicate comparisons

Olivier Brunel jjk at jjacky.com
Thu Oct 10 04:21:39 PDT 2013


On 10/10/13 12:38, Carlos Silva wrote:
> On Thu, Oct 10, 2013 at 5:14 AM, Tero Roponen <tero.roponen at gmail.com>
>  wrote:
> 
>> Testing for y > x is the same as testing for x < y.
>>
> 
> 
>> -        if (y > x)
>> +        if (x > y)
>>
> <snip>
> 
> I thing you forgot to change the signs ;)

No, I believe that was the point of the patch. The two tests were the
same, first testing (x < y), and then (y > x). Now it then properly
tests for (x > y)

-j

> 
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> 



More information about the systemd-devel mailing list