[systemd-devel] [PATCH] Add support for Intel Rapid Start

[Matthew Garrett]

On Sun, Oct 13, 2013 at 10:09:28PM +0200, Bastien Nocera wrote:
> On Sun, 2013-10-13 at 20:57 +0100, Matthew Garrett wrote:
> > On Sun, Oct 13, 2013 at 09:50:59PM +0200, Bastien Nocera wrote:
> > 
> > > +        r = read_one_line_file("/sys/bus/acpi/devices/INT3392:00/wakeup_events", &p);
> > 
> > /sys/bus/acpi/drivers/intel_rapid_start/*/wakeup_events would be better, 
> > if there's any way to use wildcards here. It's possible that later 
> > models will change the ACPI ID while still exposing the same userspace 
> > UI.
> 
> There's no way to use globs here, but I can look for the first directory
> under there, would that be enough? systemd developers, is there a helper
> for that already?

Hrm. What defines "first directory"? There's also a "module" directory, 
which makes things harder. I guess there's an argument for integrating 
this into the core kernel power management in some way - I'll talk to 
Rafael about that in Edinburgh.

> Then we shouldn't check the value, and set it, but I'm not sure I should
> be doing that in the has_rapid_start() function.

Sounds fair.

> I guess that in the future, we should allow setting and modifying the
> wakeup timer value, but I'd want to figure out if and how to present it
> in the UI before that. I'd be happy with a decent default value like 2
> hours and be done with it.

Sure.

-- 
Matthew Garrett | mjg59 at srcf.ucam.org