[systemd-devel] [PATCH] Add support for Intel Rapid Start

Bastien Nocera hadess at hadess.net
Sun Oct 13 15:54:29 PDT 2013


On Sun, 2013-10-13 at 22:45 +0200, Lennart Poettering wrote:
> On Sun, 13.10.13 22:40, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:
> 
> Humm. So I am very conservative regarding adding vendor specific hacks
> to userspace that go that low-level into the system. Given that the
> kernel has support for interl rapidstart anyway, why isn't this exposed
> properly as a new suspend mode, that we can process like any other of
> the existing ones?
> 
> THis really looks like something where the kernel should be fixed first,
> and where we then can add support in systemd for, but where we shouldn't
> try to work-around incomplete kernel interfaces from userspace...

Nothing to add here. This patch would work right now, and I knew that I
could hack systemd's user-space code instead of the kernel PM code :)

FWIW, I since found out that the patch I linked to fails, as the glob
fails. This is my 1 AM patch:
-        k = glob(optarg, GLOB_NOSORT|GLOB_BRACE, NULL, &g);
+        k = glob(path, GLOB_NOSORT|GLOB_BRACE, NULL, &g);

Cheers



More information about the systemd-devel mailing list