[systemd-devel] [PATCH] Smack enabled systems need /dev special devices correctly labeled

[Zbigniew Jędrzejewski-Szmek]

On Mon, Oct 14, 2013 at 04:28:47PM -0700, Michael Demeter wrote:
> - Add AC_DEFINE for HAVE_SMACK to configure.ac
> - Add check for smack in Makefile.am to include smack default rules
> - Add smack default rules to label /dev/xxx correctly for access
> - Whitespace fixes
> 
> Signed-off-by: Michael Demeter <michael.demeter at intel.com>
Hi,
this is not specific to your patch, I'm just using it as an example...

Please, please:

a) version your patches with [PATCH v3] etc.
b) add a note saying what changed in this version compared
   to the previous version of the patch
c) use --in-reply-to, to get proper threading.

Doing neither a) nor c) is especially bad, because if someone
replies in the earlier thread, most people will see the earlier
version of the patch below the later one.

As a bonus:
d) Don't add Signed-off-by, not used here.
e) Don't top-post, especially not the signature.

Thanks,
Zbyszek