[systemd-devel] [systemd-commits] src/bootchart

[Kok, Auke-jan H]

On Tue, Oct 15, 2013 at 6:44 AM, Zbigniew Jędrzejewski-Szmek
<zbyszek at kemper.freedesktop.org> wrote:
>  src/bootchart/store.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> New commits:
> commit 306e6650221d88b29831bcdcef94447afb65df5c
> Author: Igor Zhbanov <i.zhbanov at samsung.com>
> Date:   Tue Oct 15 14:35:13 2013 +0400
>
>     Fix for SIGSEGV in systemd-bootchart on short-living processes
>
>     The function svg_ps_bars() dereferencess NULL pointer in the line
>         endtime = ps->last->sampledata->sampletime;
>     because of partially initialized ps_struct (ps->last == NULL).
>
>     If some process terminates between scaning /proc directory in the log_sample()
>     function and reading additional information from /proc/PID/... files,
>     the files couldn't be read, the loop will be continued and partially
>     initialized structure returned.


ahhh neat, thanks, that must have been a hard one to spot!

Auke