[systemd-devel] [systemd-commits] autogen.sh src/core src/shared src/tmpfiles

[Kay Sievers]

On Mon, Oct 21, 2013 at 4:25 PM, Kay Sievers <kay at vrfy.org> wrote:
> On Mon, Oct 21, 2013 at 3:57 PM, Zbigniew Jędrzejewski-Szmek
> <zbyszek at in.waw.pl> wrote:
>> On Mon, Oct 21, 2013 at 06:48:11AM -0700, Kay Sievers wrote:
>>>  autogen.sh                    |    2 +-
>>>  src/core/machine-id-setup.c   |    2 +-
>>>  src/core/manager.c            |    2 +-
>>>  src/shared/ask-password-api.c |    3 ++-
>>>  src/tmpfiles/tmpfiles.c       |    7 +++++--
>>>  5 files changed, 10 insertions(+), 6 deletions(-)
>>>
>>> New commits:
>>> commit df28bc0836ad6a79cb537ad0b463819738088f3e
>>> Author: Kay Sievers <kay at vrfy.org>
>>> Date:   Mon Oct 21 15:24:18 2013 +0200
>>>
>>>     build-sys: use -Og instead of -O0 to catch warnings
>> Hi Kay,
>>
>> I like -Og, but there are bugs in gcc and/or libraries which cause
>> that a build with -Og to fail in some open() invocations:
>>
>> On up-to-date F20:
>>
>>   CC       src/core/libsystemd_core_la-dbus-execute.lo
>> In file included from /usr/include/fcntl.h:302:0,
>>                  from ../src/core/execute.c:25:
>> In function 'open',
>>     inlined from 'open_null_as' at ../src/core/execute.c:196:12:
>> /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
>>     __open_missing_mode ();
>>                         ^
>> make[2]: *** [src/core/libsystemd_core_la-execute.lo] Error 1
>
> Hmm, I'm running up-to-date F20, from today here. And have no issues.
> Tried a "git clean"?

Oh, didn't know older gccs are that picky, but yum update on F20 should fix it.

Can we fix the warnings with the older gccs, or should we use -O2 for
the time being, -O0 is really not good enough, it does not catch
important and real bugs, and I'm tired of looking at distcheck and
need to fix stuff all the time.

Kay