[systemd-devel] [PATCH v2] zsh-completion: add missing options for systemd-run

[William Giokas]

On Thu, Oct 31, 2013 at 09:54:05PM +0100, Ronny Chevalier wrote:
> 2013/10/31 William Giokas <1007380 at gmail.com>:
> > Much better. Now one thing that would make this amazing is if you could
> > make __machines an autoloaded file, possibly _sd_machines, that can be
> > used in multiple zsh completions so that work doesn't have to be
> > duplicated between this and _machinectl, similar to the work done with
> > _sd_hosts_or_user_at_host. And possibly split this into two patches, one
> > that just adds the -H/--host line and another that adds the -M/--machine
> > line, the _sd_machines file and has _machinectl use _sd_machines.
> >
> > Just a thought.
> Yes okay, but I think we should keep this patch and send an other one
> which add the _sd_machines file, and use it in _systemd-run and
> _machinectl, like you said. Otherwise I don't see the point of a patch
> adding the host option, but not the other one missing.
> This second patch would also fix some other parts of the completion.
> Like in _systemd-nspawn where we could use _users for --user and make
> _outputmodes an autoloaded file, since both _journalctl and _systemctl
> use it.

Okay. +1 from me.

-- 
William Giokas | KaiSforza | http://kaictl.net/
GnuPG Key: 0x73CD09CF
Fingerprint: F73F 50EF BBE2 9846 8306  E6B8 6902 06D8 73CD 09CF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20131031/0c5db96b/attachment.pgp>