[systemd-devel] [PATCH] units: add [Install] blocks for the binfmt_misc units

[Lennart Poettering]

On Fri, 06.09.13 15:19, Ross Burton (ross.burton at intel.com) wrote:

> If the administrator disables systemd-binfmt it can't be re-enabled correctly
> because there is no [Install] block, the symlinks to sysinit being created at
> install time manually.  Add an Install block so that the those symlinks can be
> re-created using systemctl, and a dependency on the automounter in
> systemd-binfmt.

I figure this is solved by now, but one thing I wanted to say:

It's a good idea to either statically enable specific units, or allow to
dynamically enable them (by adding [Install]), but I don't think it is a
good idea to support both at the same time, that'd just make things even
more confusing.

The binfmt bits are currently statically enabled by default, hence they
should not carry [Install]. We enable them by default since normally
that should not be a problem: they are skipped automatically if the
kernel has binfmt_misc disabled. So they just work if enabled in the
kernel, and they are a NOP if disabled in the kernel.

The exception of course if binfmt_misc was enabled in the kernel but the
kmod is missing, for example because the kernel has been split into
multiple packages. In this case I'd recommend to just do the same split
for the systemd build and also seperate out the systemd binfmt units
plus the symlinks that enable them. (But as I read the thread this has
already been suggested).

Lennart

-- 
Lennart Poettering - Red Hat, Inc.