[systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

[Lennart Poettering]

On Fri, 23.08.13 15:51, Colin Walters (walters at verbum.org) wrote:

> 
> First, thanks for working on this, most of these patches look sane to
> me.
> 
> On Fri, 2013-08-23 at 15:09 +0800, Tom Gundersen wrote:
> 
> > +        if (path_equal(m->where, "/") ||
> > +            path_equal(m->where, "/usr"))
> > +                return false;
> 
> But it annoys me that we're propagating this hardcoding in the new code
> too.  How about we make systemd inspect /proc/self/mountinfo *very*
> early on at boot when it starts, and ensure skip unmounting these, under
> the assumption they'll be taken care of either in the initrd, or by the
> final kill spree?

I'd actually prefer having an explicit blacklist for this, so that we
don't have to trust the initrd too much that...

However, I'd really like to see this blacklist be unified
somewhere. Maybe a new function in util.c or so called
is_os_resource_path() or so? It should probably be changed to use
NULSTR_FOREACH or so for the list, so that it is easy to add more
entries when we need that...

Lennart

-- 
Lennart Poettering - Red Hat, Inc.