[systemd-devel] [PATCH 3/4] test-utf8: add more tests for public functions

Dave Reisner dreisner at archlinux.org
Wed Sep 18 12:56:54 PDT 2013


---
Really would be great to switch over to something like cunit....

 src/test/test-utf8.c | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/src/test/test-utf8.c b/src/test/test-utf8.c
index d1ec4db..e753950 100644
--- a/src/test/test-utf8.c
+++ b/src/test/test-utf8.c
@@ -34,9 +34,43 @@ static void test_utf8_validate(void) {
         assert_se(!utf8_validate("\341\204"));
 }
 
+static void test_ascii_is_valid(void) {
+        assert_se(ascii_is_valid("alsdjf\t\vbarr\nba z"));
+        assert_se(!ascii_is_valid("\342\204\242"));
+        assert_se(!ascii_is_valid("\341\204"));
+}
+
+static void test_ascii_filter(void) {
+        char *f;
+
+        f = ascii_filter("alsdjf\t\vbarr\nba z");
+        assert_se(streq(f, "alsdjf\t\vbarr\nba z"));
+        free(f);
+
+        f = ascii_filter("\342\204\242");
+        assert_se(streq(f, ""));
+        free(f);
+
+        f = ascii_filter("foo\341\204bar");
+        assert_se(streq(f, "foobar"));
+        free(f);
+}
+
+static void test_utf8_encoded_valid_unichar(void) {
+        assert_se(utf8_encoded_valid_unichar("\342\204\242") == 3);
+        assert_se(utf8_encoded_valid_unichar("\302\256") == 2);
+        assert_se(utf8_encoded_valid_unichar("a") == 1);
+        assert_se(utf8_encoded_valid_unichar("\341\204") < 0);
+        assert_se(utf8_encoded_valid_unichar("\341\204\341\204") < 0);
+
+}
+
 int main(int argc, char *argv[]) {
         test_utf8_validate();
         test_utf8_is_printable();
+        test_ascii_is_valid();
+        test_ascii_filter();
+        test_utf8_encoded_valid_unichar();
 
         return 0;
 }
-- 
1.8.4



More information about the systemd-devel mailing list