[systemd-devel] [PATCH] fstab-generator: When parsing the root= cmdline option, set FsckPassNo to 1

[Lennart Poettering]

On Mon, 30.09.13 00:32, Thomas Bächler (thomas at archlinux.org) wrote:

> diff --git a/src/fstab-generator/fstab-generator.c b/src/fstab-generator/fstab-generator.c
> index 9efccb9..6cecb4e 100644
> --- a/src/fstab-generator/fstab-generator.c
> +++ b/src/fstab-generator/fstab-generator.c
> @@ -449,7 +449,7 @@ static int parse_new_root_from_proc_cmdline(void) {
>          }
>  
>          log_debug("Found entry what=%s where=/sysroot type=%s", what, type);
> -        r = add_mount(what, "/sysroot", type, opts, 0, noauto, nofail, false,
> +        r = add_mount(what, "/sysroot", type, opts, 1, noauto, nofail, false,
>                        SPECIAL_INITRD_ROOT_FS_TARGET, "/proc/cmdline");

Hmm, Harald, how is this supposed to work?

Originally the intention was that root-fsck.service would run fsck for
the root device, anf fsck at .service would be used for the rest. The
difference is mostly one about ordering, i.e. root-fsck.service is the
only one that is fine with the fs being already mounted.

Now, if we have the initrd, then I figure root-fsck.service doesn't make
much sense, but there's something missing I think: if we use
fsck at .service for the root device, how do we then communicate to the
root-fsck.service on the host that the file system has already been
checked? How is that supposed to work?

Harald? What is the idea here?

Lennart

-- 
Lennart Poettering - Red Hat, Inc.