[systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

[Tom Gundersen]

On Mon, Apr 7, 2014 at 12:28 PM, Susant Sahani <susant at redhat.com> wrote:
>> +        r = manager_init_kmod_ctx(m);
>> Maybe just do
>>
>> manager->kmod_ctx = kmod_ctx_new(NULL, NULL);
>> if (!manager->kmod_ctx) {
>>          r = -ENOMEM;
>>          etc...
>> }
>>
>> and drop the wrapping function (see above).
>
> Any specific reason to drop it   and do directly ?

Either way is fine. I just suggested the wrapper is not really adding
much once you drop the unref() from it.

Cheers,

Tom