[systemd-devel] [PATCH] metadata: reflect change in task_cgroup_name

[Daniel Mack]

On 04/09/2014 02:16 PM, Hristo Venev wrote:
> Change: e61734c55c24cdf11b07e52a74aec4dc4a7f4bd0.
> Merged: dc5ed40686a4da95881c35d913b60f867755cbe2 in 3.15-rc1.
> 
> task_cgroup_name returns a pointer to the path or NULL if there is not
> enough space in the buffer (used to return nonnegative or -ENAMETOOLONG).

[...]

> -	ret = task_cgroup_path(current, tmp, PAGE_SIZE);
> -	if (ret >= 0)
> -		ret = kdbus_meta_append_str(meta, KDBUS_ITEM_CGROUP, tmp);
> +	path = task_cgroup_path(current, buf, PAGE_SIZE);

Eh. Thanks for spotting this. However, I think we should have a compat
workaround for 3.14, for at least a couple of weeks. We can drop it
after that. Could you amend your patch for that?

Apart from that, please take care to follow the kernel CodingStyle. In
particular, we use tabs for indentation, not spaces.


Thanks,
Daniel