[systemd-devel] [PATCH] gudev: avoid using export-symbols-regex

Cristian Rodríguez crrodriguez at opensuse.org
Tue Apr 22 19:43:11 PDT 2014


There is no need for this hackery, just hide the internal
functions using glib 's  G_GNUC_INTERNAL macro.
---
 Makefile.am              | 3 +--
 src/gudev/gudevprivate.h | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 6967b6f..903d888 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -3016,8 +3016,7 @@ libgudev_1_0_la_LIBADD = \
 libgudev_1_0_la_LDFLAGS = \
 	$(AM_LDFLAGS) \
 	-version-info $(LIBGUDEV_CURRENT):$(LIBGUDEV_REVISION):$(LIBGUDEV_AGE) \
-	-export-dynamic -no-undefined \
-	-export-symbols-regex '^g_udev_.*'
+	-no-undefined
 
 src/gudev/gudevmarshal.h: src/gudev/gudevmarshal.list
 	$(AM_V_at)$(MKDIR_P) $(dir $@)
diff --git a/src/gudev/gudevprivate.h b/src/gudev/gudevprivate.h
index 52e272b..a656ff2 100644
--- a/src/gudev/gudevprivate.h
+++ b/src/gudev/gudevprivate.h
@@ -31,9 +31,9 @@
 G_BEGIN_DECLS
 
 GUdevDevice *
-_g_udev_device_new (struct udev_device *udevice);
+_g_udev_device_new (struct udev_device *udevice) G_GNUC_INTERNAL;
 
-struct udev *_g_udev_client_get_udev (GUdevClient *client);
+struct udev *_g_udev_client_get_udev (GUdevClient *client) G_GNUC_INTERNAL;
 
 G_END_DECLS
 
-- 
1.8.4.5



More information about the systemd-devel mailing list