[systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

[Kay Sievers]

On Thu, Apr 24, 2014 at 7:35 AM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Thu, 24.04.14 07:28, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:
>> > Have you checked that EOPNOTSUPP is really the error that is returned by
>> > name_to_handle_at() if the kernel has the entire syscall disabled? Note
>> > that there are two different cases to distuingish here: a file system
>> > not supporting the operation, and the kernel not supporting the
>> > syscal...
>> It's warning on everything except EOPNOTSUPP. My reasoning is:
>>
>> EOPNOTSUPP -> syscall supported, but wrong fs type, -> return false
>> ENOSYS -> syscall not supported -> warn and return false
>> any other error -> memory error or other major screw-up -> warn and return false
>
> Looks good to me then, Kay?

Sure, looks all fine.

Kay