[systemd-devel] [PATCH] networkd: do not complain about IFF_RUNNING

[Tom Gundersen]

On Sun, Apr 27, 2014 at 10:33 PM, Umut Tezduyar Lindskog
<umut.tezduyar at axis.com> wrote:
> Otherwise:
> eth0: unknown link flags gained: 0x00040 (ignoring)

Hm, so this is basically working as intended at the moment. I.e., we
log any change in the flags, either explicitly or with the above
message. However, I guess you may have a point about IFF_RUNNING, as
(as far as I can tell) it is redundant and covered by combinations of
other flags and operstate (and it is pretty confusing when we get
IFF_RUNNING when the device first appears, as the operstate is briefly
IF_OPER_UNKNOWN).

Applied the patch. Thanks.

Tom

> ---
>  src/network/networkd-link.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
> index 015a82d..a6ae3c1 100644
> --- a/src/network/networkd-link.c
> +++ b/src/network/networkd-link.c
> @@ -1129,7 +1129,7 @@ static int link_update_flags(Link *link, sd_rtnl_message *m) {
>          flags_removed = (link->flags ^ flags) & link->flags;
>          generic_flags = ~(IFF_UP | IFF_LOWER_UP | IFF_DORMANT | IFF_DEBUG |
>                            IFF_MULTICAST | IFF_BROADCAST | IFF_PROMISC |
> -                          IFF_NOARP | IFF_MASTER | IFF_SLAVE);
> +                          IFF_NOARP | IFF_MASTER | IFF_SLAVE | IFF_RUNNING);
>
>          if (flags_added & IFF_UP)
>                  log_debug_link(link, "link is up");
> --
> 1.7.10.4
>
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel