[systemd-devel] [PATCH] ldconfig: dont run it if ldconfig is not installed

Lennart Poettering lennart at poettering.net
Sun Aug 3 17:19:24 PDT 2014


On Wed, 30.07.14 09:02, Umut Tezduyar Lindskog (umut.tezduyar at axis.com) wrote:

> ---
>  units/ldconfig.service |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/units/ldconfig.service b/units/ldconfig.service
> index 43c145b..09a2b74 100644
> --- a/units/ldconfig.service
> +++ b/units/ldconfig.service
> @@ -13,6 +13,7 @@ Conflicts=shutdown.target
>  After=systemd-readahead-collect.service systemd-readahead-replay.service systemd-remount-fs.service
>  Before=sysinit.target shutdown.target systemd-update-done.service
>  ConditionNeedsUpdate=/etc
> +ConditionFileIsExecutable=/sbin/ldconfig
>  
>  [Service]
>  Type=oneshot

Ummmmmhh... Do we really want this? I presume you are not using glibc,
are you?

I mean, whether ldconfig is around or not is not really an admin
decision, it's an OS vendor decision. Because of that we should probably
make shiping the ldconfig service file optional, rather then always ship
it but then conditionalize it...

I'd prefer to keep conditions rather minimal in general...

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list