[systemd-devel] [PATCH] Fix compilation under clang/LLVM

[Greg KH]

On Tue, Aug 05, 2014 at 07:58:47PM -0500, Dan McGee wrote:
> Compilation is failing because we are doing something not allowed by the
> language spec, but OK by GCC extensions in our MAX() macro.
> 
> src/resolve/resolved-manager.c:759:43: error: non-const static data member must be initialized out of line
>                 uint8_t buffer[CMSG_SPACE(MAX(sizeof(struct in_pktinfo), sizeof(struct in6_pktinfo)))
>                                           ^
> 
> Add a new constant that does this in a way both compilers are OK with,
> since we know all factors in the size computation are static.

Why not just fix MAX()?

thanks,

greg k-h