[systemd-devel] [PATCH 1/3] logind: session: don't set /dev/ttyX owner to root on restore_vt

[Lennart Poettering]

On Fri, 08.08.14 20:45, Olivier Brunel (jjk at jjacky.com) wrote:

> In session_prepare_vt() we set owner of /dev/ttyX to the user, as that is
> needed for things to work. However, we shouldn't "reset" it to root on
> session_restore_vt() since it could have in fact already been set to
> the user.

I don't follow here, can't parse this. Could you please elaborate? 

> ---
>  src/login/logind-session.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/login/logind-session.c b/src/login/logind-session.c
> index fdeacb1..905e73f 100644
> --- a/src/login/logind-session.c
> +++ b/src/login/logind-session.c
> @@ -1070,8 +1070,6 @@ void session_restore_vt(Session *s) {
>          mode.mode = VT_AUTO;
>          ioctl(vt, VT_SETMODE, &mode);
>  
> -        fchown(vt, 0, -1);
> -
>          s->vtfd = safe_close(s->vtfd);
>  }
>  


Lennart

-- 
Lennart Poettering, Red Hat