[systemd-devel] [PATCH] udev: warn instead of killing kmod loading

Lennart Poettering lennart at poettering.net
Mon Aug 11 09:57:06 PDT 2014


On Mon, 11.08.14 18:39, Luis R. Rodriguez (mcgrof at suse.com) wrote:

> > This looks really wrong. We shouldn't permit worker processes to be
> > blocked indefinitely without any timeout applied. Designing a worker
> > process system like that is simply wrong. It's one thing to allow
> > changing the specific timeout applied, it's a very different thing to
> > allow broken drivers to completely stall the worker process logic.
> 
> OK what if we enable customizations then on the timeout by the built-in
> cmd type and we use a high multiplier for now for kmod ? A multiplier
> for kmod of 10 would set the kmod timeout to 5 minutes then, as we
> sweep up and clean drivers we can reduce this over time. This would also
> enable us to keep the default timeout for the other type of workers.

Why this complexity?

I mean, it sounds much simpler to simply increase the default timeout a
bit, if it turns out to be too low for the current cases...

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list