[systemd-devel] [PATCH v3] readahead: use BTRFS_IOC_DEFRAG_RANGE

Lennart Poettering lennart at poettering.net
Thu Aug 14 10:08:50 PDT 2014


On Mon, 21.07.14 20:23, Timofey Titovets (nefelim4ag at gmail.com) wrote:

> Just completed TODO:
> * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG
> ioctl, with START_IO

Hmm, the patch is line broken...

But this patch only replaces one ioctl with another right? It doesn't
actually improve anything effectively, does it?

I am not really convinced that we should make this change, maybe we
should remove readahead from the the package instead...

> 
> commit d3fc81bd6a5a046b22600ac1204df220c93d2c15 refs/tags/v30
> Author: Lennart Poettering <lennart at poettering.net>
> Date:   Wed Jun 15 15:39:10 2011 +0200
> 
>     update TODO
> 
> i no add this todo in TODO list (recursively todo %), and as this my
> opinion may be not relevant with author.
> 
> As i understand start_io option force write data after defragment,
> without buffering it in memory.
> 
> 
> v1 -> v2
> Fixed spelling in TODO
> 
> v2 -> v3
> Deleted todo from code
> Fix compilation issues
> Delete fallback code, because BTRFS_IOC_DEFRAG_RANGE supported as
> 2.6.29 oldest longterm 2.6.32.63
> 

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list