[systemd-devel] [PATCH v2] Refuse mount on symlink

[Timofey Titovets]

Okay, i will rebase and resend, and add warning
But what i must do with message:
"symlink.mount failed to run 'mount' task: Too many levels of symbolic links"?
Just leave and add additional massage error or replace?

2014-08-14 20:31 GMT+03:00 Timofey Titovets <nefelim4ag at gmail.com>:
> Okay, i will rebase and resend, and add warning
> But what i must do with message:
> "symlink.mount failed to run 'mount' task: Too many levels of symbolic links"?
> Just leave and add additional massage error or replace?
>
> 2014-08-14 20:05 GMT+03:00 Lennart Poettering <lennart at poettering.net>:
>> On Mon, 21.07.14 19:24, Timofey Titovets (nefelim4ag at gmail.com) wrote:
>>
>> Doesn't apply to current git. Could you please rebase on current git?
>>
>>>
>>> +int fail_if_symlink(const char *unit, const char* where) {
>>> +        assert(where);
>>> +
>>> +        if (!is_symlink(where))
>>> +                return 0;
>>
>> This should probably be "if (is_symlink(where) > 0)".
>>
>> Also I think we should print an explicit message here, that tells the
>> admin that mounting symlinks is not supported.
>>
>> Sorry for the long delay in responding.
>>
>> Lennart
>>
>> --
>> Lennart Poettering, Red Hat
>
>
>
> --
> Best regards,
> Timofey.



-- 
Best regards,
Timofey.