[systemd-devel] [RFC][PATCH] socket: show full instance name in services' description

Lennart Poettering lennart at poettering.net
Thu Aug 14 16:18:55 PDT 2014

On Tue, 15.07.14 16:36, Łukasz Stelmach (l.stelmach at samsung.com) wrote:

> Change the way socket activated services are instantiated so that the
> full instnace name with addresses of both parties and not only the
> counter make it into units' descriptions visible in the journal.

Hmm, what I really don't like about this scheme is the selinux handling,
i.e. previously we just pre-allocated a stream when we had to label the
socket, and then used it much later, when the first actual connection
was coming in. Allocating and then freeing it immediately during
labelling sounds not so attractive to me.

Maybe we can fix this problem differently. I mean we use
unit_choose_id() to make sure the primary name for the unit is the
pretty one. Maybe we can find a way how to make sure that the log
messages you are interested in are only generated after that? 

So, hmm, which log messages are you interested in particular to carry
the final name?


Lennart Poettering, Red Hat

More information about the systemd-devel mailing list