[systemd-devel] [systemd-commits] man/journalctl.xml src/journal

[Zbigniew Jędrzejewski-Szmek]

On Thu, Aug 21, 2014 at 05:16:37AM -0700, Harald Hoyer wrote:
> @@ -276,6 +278,7 @@ static int parse_argv(int argc, char *argv[]) {
>                  { "file",           required_argument, NULL, ARG_FILE           },
>                  { "root",           required_argument, NULL, ARG_ROOT           },
>                  { "header",         no_argument,       NULL, ARG_HEADER         },
> +                { "identifier",     required_argument, NULL, 't'                },
>                  { "priority",       required_argument, NULL, 'p'                },
>                  { "setup-keys",     no_argument,       NULL, ARG_SETUP_KEYS     },
>                  { "interval",       required_argument, NULL, ARG_INTERVAL       },
> @@ -304,7 +307,7 @@ static int parse_argv(int argc, char *argv[]) {
>          assert(argc >= 0);
>          assert(argv);
>  
> -        while ((c = getopt_long(argc, argv, "hefo:aln::qmb::kD:p:c:u:F:xrM:", options, NULL)) >= 0)
> +        while ((c = getopt_long(argc, argv, "hefo:aln::qmb::kD:p:c:t:u:F:xrM:", options, NULL)) >= 0)

Hi,

I think the addition is useful, but I'm not sure we want to immediately allocate
the short option too. So far syslog identifier haven't been in much use, and
't' is a nice option name.

Zbyszek