[systemd-devel] Bug#758050: udev: ID_VENDOR_FROM_DATABASE, ID_MODEL_FROM_DATABASE for unrecognised USB device are taken from USB hub

[Kay Sievers]

On Thu, Aug 14, 2014 at 9:01 PM, Kay Sievers <kay at vrfy.org> wrote:
> On Thu, Aug 14, 2014 at 3:07 PM, Simon McVittie
> <simon.mcvittie at collabora.co.uk> wrote:
>> I recently opened this Debian bug, for which I attach a
>> patch that seems to work. Bug report quoted in full below.
>>
>> I would appreciate udev maintainers' opinions on whether this is
>> likely to break non-USB devices, or whether there is a better way
>> to do it.
>
> Maybe replace streq(dsubsys, "usb") with a specific match on " devtype
> == usb_device" (sysfs hierarchy is usb_interface -> usb_device) and if
> we hit that, we make sure we stop looking at any of the parents?

Pushed a fix, similar to your patch, with the above explicit check for
"usb_device".

Thanks,
Kay