[systemd-devel] [PATCH] sd-bus: kdbus: monitor connections use the KDBUS_HELLO_MONITOR flag

[Lennart Poettering]

On Fri, 22.08.14 16:40, Djalal Harouni (tixxdz at opendz.org) wrote:

I have removed the call now, as it is indeed unused, and we already have
full monitor support in the library itself, so this will never be used.

Thanks for the notification.

> ---
> Currently this bus_kernel_create_monitor() is not used.
> 
> Patch compile tested.
> 
>  src/libsystemd/sd-bus/bus-kernel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libsystemd/sd-bus/bus-kernel.c b/src/libsystemd/sd-bus/bus-kernel.c
> index 3ca271c..1440e43 100644
> --- a/src/libsystemd/sd-bus/bus-kernel.c
> +++ b/src/libsystemd/sd-bus/bus-kernel.c
> @@ -1547,7 +1547,7 @@ int bus_kernel_create_monitor(const char *bus) {
>  
>          hello = alloca0(sizeof(struct kdbus_cmd_hello));
>          hello->size = sizeof(struct kdbus_cmd_hello);
> -        hello->conn_flags = KDBUS_HELLO_ACTIVATOR;
> +        hello->conn_flags = KDBUS_HELLO_MONITOR;
>          hello->pool_size = KDBUS_POOL_SIZE;
>  
>          if (ioctl(fd, KDBUS_CMD_HELLO, hello) < 0) {


Lennart

-- 
Lennart Poettering, Red Hat