[systemd-devel] [PATCH 0/2] units: add and use ConditionInitrd= instead of checking for /etc/initrd-release.

[Ivan Shapovalov]

On Wednesday 27 August 2014 at 20:19:45, Lennart Poettering wrote:	
> On Wed, 27.08.14 20:26, Ivan Shapovalov (intelfx100 at gmail.com) wrote:
> 
> > This is as proposed by Thomas in review of my hibernate-resume patchset.
> > 
> > The objective benefit of this change is that in_initrd() function is used
> > for checking, which not only checks for /etc/initrd-release, but also verifies
> > that the rootfs is on a virtual device.
> 
> If we add a new condition then I want to hear a strong case for it. I
> mean, what's wrong with checking for initrd-release? Why would that not
> suffice?
> 
> We should be really careful when it comes to an inflation of conditions...

Let's just cc Thomas Bächler who proposed this. Personally I see only one
benefit (which is described in cover letter)...

-- 
Ivan Shapovalov / intelfx /
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20140827/71fd180d/attachment.sig>