[systemd-devel] [PATCH 0/2] units: add and use ConditionInitrd= instead of checking for /etc/initrd-release.

[Lennart Poettering]

On Thu, 28.08.14 19:44, Thomas Bächler (thomas at archlinux.org) wrote:

> Am 27.08.2014 um 22:48 schrieb Thomas Bächler:
> > Am 27.08.2014 um 20:25 schrieb Ivan Shapovalov:
> >> On Wednesday 27 August 2014 at 20:19:45, Lennart Poettering wrote:	
> >>> On Wed, 27.08.14 20:26, Ivan Shapovalov (intelfx100 at gmail.com) wrote:
> >>>
> >>>> This is as proposed by Thomas in review of my hibernate-resume patchset.
> >>>>
> >>>> The objective benefit of this change is that in_initrd() function is used
> >>>> for checking, which not only checks for /etc/initrd-release, but also verifies
> >>>> that the rootfs is on a virtual device.
> >>>
> >>> If we add a new condition then I want to hear a strong case for it.
> 
> On that note, where's the "strong case" for 'ConditionFirstBoot='? It's
> equivalent to ConditionPathExists=/run/systemd/first-boot. And it's
> needed in a single service. What makes this different from ConditionInitrd=?

Well, the difference is that checking for /etc/initrd-release (which we
should actually move to /usr/lib/initrd-release similar to
/usr/lib/os-release...) is kinda official API, but
/run/systemd/first-boot is internal stuff...

People are supposed to parse the initrd-release file, but not our
internal ones...

Lennart

-- 
Lennart Poettering, Red Hat