[systemd-devel] [PATCH] journal/compress: use LZ4_compress_continue()

Evangelos Foutras evangelos at foutrelis.com
Sat Aug 30 15:00:45 PDT 2014


On 31 August 2014 00:39, Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> wrote:
> On Sat, Aug 30, 2014 at 10:13:43AM +0300, Evangelos Foutras wrote:
>> We can't use LZ4_compress_limitedOutput_continue() because in the
>> worst-case scenario the compressed output can be slightly bigger than
>> the input block. This generally affects very few blocks and is no reason
>> to abort the compression process.
> Applied.
>
> We should probably do the same for XZ.

I don't believe compress_stream_xz() has this problem, or at least I
didn't notice any issues with Chromium core dumps; they were
successfully stored as .xz files.

(Sorry for the duplicate email, I failed to reply to the list in my
earlier response.)


More information about the systemd-devel mailing list