[systemd-devel] [PATCH] journalctl: Fix --list-boots and --boot

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Sun Aug 31 06:32:21 PDT 2014


On Sun, Aug 31, 2014 at 10:47:25AM +0200, Jan Janssen wrote:
> 
> 
> On 2014-08-30 23:46, Zbigniew Jędrzejewski-Szmek wrote:
> >On Fri, Aug 29, 2014 at 06:11:35PM +0200, Jan Janssen wrote:
> >>For some reason, sd_journal_query_unique() and sd_journal_add_match() don't
> >>work as they used to. There's a chance boots will be skipped; in my
> >>case only 60 of 393 boots show up. Therefore, do sd_journal_query_unique() first
> >>and then iterate over those to query their timespec.
> >We should fix the underlying problem, since query_unique and add_match weren't
> >supposed to change at all. Looking at the journal client code has been on my
> >TODO list for a long while...
> 
> You're probably right, but at the same time I wonder if interleaving
> query_unique and normal journal matching should be allowed/supported
> in the first place...
Manual page says "Note that these functions currently are not
influenced by matches set with sd_journal_add_match() but this
might change in a later version of this software." so it should
do something meaningful.

Zbyszek


More information about the systemd-devel mailing list