[systemd-devel] [PATCH] bootchart: add standalone bootchart service

[WaLyong Cho]

On 12/03/2014 08:30 AM, Lennart Poettering wrote:
> On Sat, 15.11.14 15:42, WaLyong Cho (walyong.cho at samsung.com) wrote:
> 
> Heya,
> 
> The suggested way to run boot chart is by specifying
> init=/usr/lib/systemd/systemd-bootchart on the kernel cmdline. What's
> the rationale behind making this a service? I mean, if it is started
> as service it races against other services and might thus not be able
> track services run in early boot. Can you please elaborate on the
> rationale for this patch?
> 
Yes, right. I'm also generate bootchart using kernel command line. But,
in some kind of bootloader, it can be hard to modify the kernel command
line. In our mobile phone, we do not allow to modify kernel command line
to protect from hacking. In this case, this service can be useful even
if some of processes can not be shown. But according to this service
dependency, I think this bootchart service will be activated quite ahead
of boot sequence.
And as you said, this will race against others. That why this should NOT
be enabled as default. But if someone want to get bootchart easily then
he can get bootchart after just enable this. And also I think this can
be useful to newbie. Isn't it?

WaLyong

>> ---
>>  Makefile.am                        |  9 +++++++++
>>  units/systemd-bootchart.service.in | 17 +++++++++++++++++
>>  2 files changed, 26 insertions(+)
>>  create mode 100644 units/systemd-bootchart.service.in
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 1aef242..b682606 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -4428,6 +4428,15 @@ rootlibexec_PROGRAMS += \
>>  
>>  dist_pkgsysconf_DATA += \
>>  	src/bootchart/bootchart.conf
>> +
>> +nodist_systemunit_DATA += \
>> +	units/systemd-bootchart.service
>> +
>> +EXTRA_DIST += \
>> +	units/systemd-bootchart.service.in
>> +
>> +CLEANFILES += \
>> +	units/systemd-bootchart.service
>>  endif
>>  
>>  # ------------------------------------------------------------------------------
>> diff --git a/units/systemd-bootchart.service.in b/units/systemd-bootchart.service.in
>> new file mode 100644
>> index 0000000..aafc1ea
>> --- /dev/null
>> +++ b/units/systemd-bootchart.service.in
>> @@ -0,0 +1,17 @@
>> +#  This file is part of systemd.
>> +#
>> +#  systemd is free software; you can redistribute it and/or modify it
>> +#  under the terms of the GNU Lesser General Public License as published by
>> +#  the Free Software Foundation; either version 2.1 of the License, or
>> +#  (at your option) any later version.
>> +
>> +[Unit]
>> +Description=Standalone Bootchart
>> +Documentation=man:systemd-bootchart.service(1) man:bootchart.conf(5)
>> +DefaultDependencies=no
>> +
>> +[Service]
>> +ExecStart=@rootlibexecdir@/systemd-bootchart -r
>> +
>> +[Install]
>> +WantedBy=sysinit.target
>> -- 
>> 1.9.3
>>
>> _______________________________________________
>> systemd-devel mailing list
>> systemd-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> 
> 
> Lennart
>