[systemd-devel] [PATCH 1/3] log: 1237557 Unchecked return value from library

[Lennart Poettering]

On Mon, 17.11.14 10:58, David Herrmann (dh.herrmann at gmail.com) wrote:

> Hi
> 
> On Tue, Nov 11, 2014 at 9:06 AM, Susant Sahani <susant at redhat.com> wrote:
> > fix 1237557 Unchecked return value from library
> > ---
> >  src/shared/log.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/shared/log.c b/src/shared/log.c
> > index 1c589ac..e7237ba 100644
> > --- a/src/shared/log.c
> > +++ b/src/shared/log.c
> > @@ -122,7 +122,7 @@ static int create_log_socket(int type) {
> >                  timeval_store(&tv, 10 * USEC_PER_MSEC);
> >          else
> >                  timeval_store(&tv, 10 * USEC_PER_SEC);
> > -        setsockopt(fd, SOL_SOCKET, SO_SNDTIMEO, &tv, sizeof(tv));
> > +        (void) setsockopt(fd, SOL_SOCKET, SO_SNDTIMEO, &tv, sizeof(tv));
> 
> I don't think we use spaces after casts, but not entirely sure..

I usually put a space there. And I'd recommend doing that, but we
don't follow that strictly, and either is acceptable.

Lennart

-- 
Lennart Poettering, Red Hat