[systemd-devel] [PATCH v4 3/4] unit: add UnitMask enum and get unit scope(mask) api from property

Lennart Poettering lennart at poettering.net
Thu Dec 4 15:55:08 PST 2014


On Thu, 04.12.14 17:01, WaLyong Cho (walyong.cho at samsung.com) wrote:

> On 12/04/2014 03:43 AM, Lennart Poettering wrote:
> > On Tue, 02.12.14 23:29, WaLyong Cho (walyong.cho at samsung.com) wrote:
> > 
> > Hmm, what's the rationale for this? Can you elaborate?
> 
> As you already noticed(on the 4th mail), this hash table is used to find
> unit can have a given property. As you said on 4th mail, if we use a
> special option for timer then this will not be needed.
> This can be also used in systemctl set-property and we can detect given
> property is supported by that unit or not before sending dbus. But, in
> most of case, systemctl set-property is called by user command line. And
> they will know which unit support which property. So, maybe this is not
> much needed.
> If you feel messy, I will add --timer-property= option.

Yeah, I'd prefer to keep the logic for all this on the client side
simple, and make the server side figure things out. Hence I think
--timer-property= is a good solution.

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list