[systemd-devel] [PATCH] build-sys: remove commented-out m4 from user at .service

[Zbigniew Jędrzejewski-Szmek]

On Mon, Dec 15, 2014 at 04:36:51PM +0100, Lennart Poettering wrote:
> On Sun, 14.12.14 19:12, Mantas Mikulėnas (grawity at gmail.com) wrote:
> 
> > Otherwise this actually remains in the generated unit in /usr/lib.
> > 
> > If you want to keep it commented out, a m4-compatible way would be:
> > 
> >     m4_ifdef(`HAVE_SMACK',
> >     dnl Capabilities=cap_mac_admin=i
> >     dnl SecureBits=keep-caps
> >     )
> 
> This really was only a temporary commenting, since the bits broke the
> user instance in containers. See
> 
> http://lists.freedesktop.org/archives/systemd-devel/2014-December/026188.html
> 
> We really should find a proper fix for this, instead of just removing
> the code for it.
Sure, but pulling it out of git history is trivial in either case.
And you know what they say about the durability of temporary measures...
so I thought it is better to keep the files that the user sees clean.

Zbyszek