[systemd-devel] [PATCH 0/9] capabilities: remove include of <sys/capability.h> where possible

[Filipe Brandenburger]

Ping?

Also wondering if it makes sense to go ahead and implement our own
"cap_to_text" and "cap_from_text" to generate capability strings from
the bitmaps (and further remove dependency on libcap.) I think it
does, considering we now already have our own list of valid
capabilities and the constants come from kernel headers (or
missing.h), it makes sense to have more of our own routines...

Cheers,
Filipe


On Tue, Dec 16, 2014 at 5:18 PM, Filipe Brandenburger
<filbranden at google.com> wrote:
> This is a first cleanup step towards removing the dependency on libcap.
>
> The idea of removing the libcap dependency was brought up by Lennart in:
> http://lists.freedesktop.org/archives/systemd-devel/2014-December/026155.html
>
> It is mainly removing the include of <sys/capability.h> where the only
> capability-related information used is the CAP_* constants which are actually
> coming from <linux/capability.h> (kernel headers) or from "missing.h" (for
> compatibility with older kernel headers.)
>
> Filipe Brandenburger (9):
>   capabilities: remove spurious include of <sys/capability.h> from nspawn.c
>   capabilities: remove spurious include of <sys/capability.h> from logind sources
>   capabilities: remove spurious include of <sys/capability.h> from tmpfiles.c
>   capabilities: remove spurious include of <sys/capability.h> from hostnamed.c
>   capabilities: remove spurious include of <sys/capability.h> from localed.c
>   capabilities: remove spurious include of <sys/capability.h> from timedated.c
>   capabilities: remove spurious include of <sys/capability.h> from pam_systemd.c
>   capabilities: remove spurious include of <sys/capability.h> from machined sources
>   capabilities: remove spurious include of <sys/capability.h> from sd-dbus sources
>
>  src/hostname/hostnamed.c            | 1 -
>  src/libsystemd/sd-bus/bus-objects.c | 2 --
>  src/libsystemd/sd-bus/bus-util.c    | 1 -
>  src/locale/localed.c                | 1 -
>  src/login/logind-dbus.c             | 1 -
>  src/login/logind-seat-dbus.c        | 1 -
>  src/login/logind-session-dbus.c     | 1 -
>  src/login/logind-user-dbus.c        | 1 -
>  src/login/pam_systemd.c             | 1 -
>  src/machine/machine-dbus.c          | 1 -
>  src/machine/machined-dbus.c         | 1 -
>  src/nspawn/nspawn.c                 | 2 +-
>  src/timedate/timedated.c            | 1 -
>  src/tmpfiles/tmpfiles.c             | 1 -
>  14 files changed, 1 insertion(+), 15 deletions(-)
>
> --
> 1.8.3.1
>