[systemd-devel] [PATCH 1/2] test: only use assert_se in test_raw_clone

Filipe Brandenburger filbranden at google.com
Tue Dec 23 10:14:46 PST 2014


The asserts used in the tests should never be allowed to be optimized away.
---
 src/test/test-util.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/test/test-util.c b/src/test/test-util.c
index 222af9a..57fd19b 100644
--- a/src/test/test-util.c
+++ b/src/test/test-util.c
@@ -420,7 +420,7 @@ static void check(const char *test, char** expected, bool trailing) {
                 printf("<%s>\n", t);
         }
         printf("<<<%s>>>\n", state);
-        assert(expected[i] == NULL);
+        assert_se(expected[i] == NULL);
         assert_se(isempty(state) == !trailing);
 }
 
@@ -1331,15 +1331,15 @@ static void test_raw_clone(void) {
         assert_se(raw_getpid() == parent);
 
         pid = raw_clone(0, NULL);
-        assert(pid >= 0);
+        assert_se(pid >= 0);
 
         pid2 = raw_getpid();
         log_info("raw_clone: "PID_FMT" getpid()→"PID_FMT" raw_getpid()→"PID_FMT,
                  pid, getpid(), pid2);
         if (pid == 0)
-                assert(pid2 != parent);
+                assert_se(pid2 != parent);
         else
-                assert(pid2 == parent);
+                assert_se(pid2 == parent);
 }
 
 int main(int argc, char *argv[]) {
-- 
1.8.3.1



More information about the systemd-devel mailing list